Split jvm_binary.py into jvm_binary.py and jvm_app.py.
Review Request #2006 - Created March 30, 2015 and submitted
- Moved test_jvm_app.py into the tests/python/pants_test/backend/jvm/targets directory
- Added some explicit tests for the JvmBinary target.
- Minor fix to jvm_binary.py to raise an error about the 'source' attribute before
it gets passed to the super() constructor.
CI at https://travis-ci.org/pantsbuild/pants/builds/56504009
I can see why jvm_binary and jvm_app were put in the same source file because jvm_app must live in conjunction with jvm_binary. But there is no shared code between the two targets and I want to add more code and tests to jvm_binary. It seems ripe for each living in their own source files.
This change just moves code around for the most part:
jvm_binary.py is split into jvm_app.py and jvm_binary.py
test_jvm_app.py is moved to a new directory
test_jvm_binary.py was added.
set address before calling super() in places that might raise TargetDefinitionException
Revision 2 (+333 -261)