Force java generation on for protobuf_gen, get rid of spurious warning

Review Request #1994 — Created March 26, 2015 and submitted

zundel
pants
zundel/protobuf-gen-hardcode-java
121, 1334
66291fd...
pants-reviews
jsirois, patricklaw, stuhood
Force java generation on for protobuf_gen, get rid of spurious warning

Manually tested using the repro case in https://github.com/pantsbuild/pants/pull/121

I found that setting pants.ini to

[gen.protoc]
lang: ["java"]

Enables us to compile in our repo in the latest version of pants. This allows us to get past problems that started
cropping up with the UnionDependencies change to the classpath product introduced to help with classpath hygene.

ZU
  1. If you like, I can add in the repro case in PR 121 to this change. I have mixed feelings about it since this fix is really a stopgap.

  2. 
      
PA
  1. Ship It!
  2. 
      
ZU
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks Patrick. commit 0b29805

Loading...