Don`t mutate options in the linter

Review Request #1978 — Created March 23, 2015 and submitted

stuhood
pants
ac9a37d...
pants-reviews
benjyw, nhoward_tw, tejal
  • Don`t mutate options, otherwise we end up growing this list in memory. Noticed this because scrooge complains if it receives the same option twice.

Rather than writing a test specific to options on thrift_linter, I'd like to follow up by making option values immutable (at the top level at least), to prevent any other bugs like this.



IT
  1. lgtm

  2. 
      
NH
  1. One minor style Q, but otherwise LGTM

  2. why not just do list(...linter_args)? I think that'd make it more clear that the purpose is to create a clone of the option values to modify.

    1. I think the intent is to build the set of args for scrooge, some of which are the "extra" args from the options... will leave it.

  3. 
      
JI
  1. Ship It!
  2. 
      
ST
Review request changed

Status: Closed (submitted)

Loading...