Ignore blank lines and comments in scalastyle excludes file

Review Request #1971 - Created March 22, 2015 and submitted

Information
Matthew Jeffryes
pants
7a24c65...
Reviewers
pants-reviews
benjyw, jinfeng, jsirois

Problem:
The scalastyle plugin does not skip blank lines when parsing the excludes file. Blank lines turn into empty regex patterns which then match all files. This probably not what the user had in mind.

Solution:
Skip lines consisting only of whitespace or starting with '#' when processing hte excludes file

Result:
Users of the plugin can safely include blank lines and comments in their excludes file.

./pants test tests/python/pants_test/backend/jvm/tasks:scalastyle

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
John Sirois
Andy Reitz
Stu Hood
Matthew Jeffryes
John Sirois
Andy Reitz
Matthew Jeffryes
Andy Reitz
Stu Hood
Matthew Jeffryes
Matthew Jeffryes
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 6f181d50475e2544907afe163b752c0272686576

Loading...