Fix a bad logic bug in zinc analysis split code.

Review Request #1969 — Created March 20, 2015 and submitted

benjyw
pants
b78f2db...
pants-reviews
patricklaw, stuhood
This created nonsensical external dependencies, that caused zinc
to get confused and end up invalidating anything that depending on them.

Also added a more fine-grained test so this doesn't happen again.
  • Ran scala tests manually.
  • Verified that this fixed a bug we were seeing in the Foursquare repo.
  • CI baking: https://travis-ci.org/pantsbuild/pants/builds/55263017
  • 2
  • 0
  • 1
  • 0
  • 3
Description From Last Updated
assertEquals PA patricklaw
`assertEquals PA patricklaw
PA
  1. 
      
  2. Does __file__ work as expected within a pex?

    1. No idea, but this is a test, and it passes, so I'm not concerned.

  3. A bunch of spurious whitespace in this file

    1. Not sure I concur. There's no useful __str__/__repr__ of a ZincAnalysis instance, so the "nice" message assertEquals would produce would actually be more confusing than helpful.
  4. Out of curiosity, how does this fully qualified jar path not mess things up?

    1. Why would it? This is just a test of some text munging.

  5. 
      
ST
  1. Ship It!
    1. It looks like this was introduced in https://rbcommons.com/s/twitter/r/1779/ : is that correct?

    2. Yes, that is correct.

  2. 
      
BE
BE
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as 54fade7f2f653070209af615953d46c0ba6e1d98.

Loading...