Fix publish override flag

Review Request #1959 — Created March 20, 2015 and submitted

ity
pants
https://github.com/pantsbuild/pants/pull/1296
a3fb279...
pants-reviews
jsirois, nhoward_tw, tejal
  • Fixes Issue https://github.com/pantsbuild/pants/issues/1277
  • Fix publish override flag.
  • Added a test which was failing before this change and now passes.

https://travis-ci.org/pantsbuild/pants/builds/55156159

TE
  1. Ship It!
  2. 
      
NH
  1. Hooray for regression tests!

  2. 
      
JS
  1. 
      
  2. Either "TODO(Ity Kaul): Actually test overrides work!" or else re-name the test to something like test_publish_override_doesnt_blow_up which is all this ensures right now.

  3. 
      
ST
  1. Thanks Ity.

  2. There "shouldn't" be any concurrency here, but in the face of concurrency this would allow these to be seperated.

  3. 
      
IT
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted @ 4ece17f3f5f775a37090fc1b77da7bed7905d047

Loading...