Pass compression option along to temp local artifact caches which are used to create artifacts for remote caches.

Review Request #1955 — Created March 19, 2015 and submitted

dturner-tw
pants
1c2e268...
pants-reviews
benjyw, jsirois, stuhood
Additionally, gzipping is now always turned on, although it can be set
to gzip at level 0, which does not compress.  Python's tarfile will
happily untar truncated or corrupted tars, but a corrupted gzip file
will have a bad checksum and will throw an exception.  This improves
reliability.

https://travis-ci.org/pantsbuild/pants/builds/55119711 running (but the cache tests pass locally)

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
DT
ST
  1. 
      
  2. src/python/pants/cache/cache_setup.py (Diff revision 1)
     
     

    Rather than defaulting this here, maybe it should be a required argument? The --cache-compression option has a default already, and it shouldn't be ignored.

  3. 
      
DT
ST
  1. Thanks David! Great work.

  2. ditto

  3. 
      
DT
JS
  1. Ship It!
  2. 
      
IT
  1. Ship It!
  2. 
      
DT
Review request changed

Status: Closed (submitted)

BE
  1. Ship It!
  2. 
      
PA
  1. 
      
  2. src/python/pants/cache/cache_setup.py (Diff revision 4)
     
     

    if compression in range(10) is less awkward than the type check and will check precisely that it's a valid input.

  3. 
      
Loading...