Pass compression option along to temp local artifact caches which are used to create artifacts for remote caches.

Review Request #1955 - Created March 20, 2015 and submitted

Information
David Turner
pants
1c2e268...
Reviewers
pants-reviews
benjyw, jsirois, stuhood
Additionally, gzipping is now always turned on, although it can be set
to gzip at level 0, which does not compress.  Python's tarfile will
happily untar truncated or corrupted tars, but a corrupted gzip file
will have a bad checksum and will throw an exception.  This improves
reliability.

https://travis-ci.org/pantsbuild/pants/builds/55119711 running (but the cache tests pass locally)

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
David Turner
Stu Hood
David Turner
Stu Hood
David Turner
John Sirois
Ity Kaul
David Turner
Review request changed

Status: Closed (submitted)

Benjy Weinberger
Ship It!
Patrick Lawson

   
src/python/pants/cache/cache_setup.py (Diff revision 4)
 
 

if compression in range(10) is less awkward than the type check and will check precisely that it's a valid input.

Loading...