Get rid of almost all direct config access in python-building code.

Review Request #1954 — Created March 20, 2015 and submitted

benjyw
pants
401a692...
pants-reviews
jsirois, wickman

- Instead, relies more heavily on the existing PythonSetup class,
and a new sibling called PythonRepos.
- These are basically proto-subsystems, and we'll retrofit them
to be part of the subsystem mechanism once we invent that.
- Removes some unnecessary degrees of freedom in config.
For example, there's no reason to allow names of working and scratch dirs
to be configurable.
- Cleans up and streamlines the code.
- Moves some standalone functions into classes, for a more natural design.
- Refactors a test for better code reuse.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/55115225

Tried various manual python builds.

JS
  1. Nice.
  2. kill trailing ws
  3. Oh my jesus - you share a gene with Wickman here ... although he was the one to pick the indices form.
    1. That 'indices' really bugged be because it seems so wrong in this context.

  4. Odd linebreak here, [self._interpreter] can be on its own line.
  5. 
      
BE
BE
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as 8143e76463ea5883fa9c511ce5d59255064132a6.

Loading...