Refactor ZincUtils.

Review Request #1946 — Created March 19, 2015 and submitted

benjyw
pants
1e22771...
pants-reviews
patricklaw, stuhood

Much of its structure was due to it previously being used not just
for compilation but also for split/merge/rebase. But now that we do those
directly in Pants code, we can simplify and streamline ZincUtils.

- Concentrates zinc argument construction in one place. Previously
args got added piecemeal.
- Ensures that we invalidate on changes in scalac options (including
plugins).
- Removes a superfluous sorting of invalidation arguments (the JvmFingerprintStrategy
sorts them anyway).
- Simplifies a test and adds a new test.
- Replaces a direct config access with an option.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/54951792

Manual testing of scala compiles.

BE
ST
  1. Thanks for doing this. Looks much better.

  2. apparently this should be self. now?

    1. Well, the caller is a staticmethod, so it doesn't have a self. But I can make it a classmethod and have it call cls.

  3. 
      
BE
BE
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as 7ea504b1a94a93e84364db882b9b064644b69055.

Loading...