Prepare for the 0.0.30 release.

Review Request #1941 — Created March 18, 2015 and submitted

jsirois
pants
jsirois/release/prep_0.0.30
1285
61066e8...
pants-reviews
benjyw, ity, lahosken, mateor, nhoward_tw, patricklaw, zundel
This removes all deprecated items slated for removal and fixes up the
release script to force a clean master and a signed tag if all goes
well.

 build-support/bin/release.sh                           |  16 ++++-
 src/python/pants/CHANGELOG.rst                         | 168 +++++++++++++++++++++++++++++++++++++++++++++++---
 src/python/pants/backend/jvm/targets/BUILD             |   1 -
 src/python/pants/backend/jvm/targets/jar_dependency.py |  10 ---
 src/python/pants/backend/jvm/targets/jvm_binary.py     |  12 ----
 src/python/pants/base/BUILD                            |   1 -
 src/python/pants/base/target.py                        |  41 ------------
 src/python/pants/version.py                            |   2 +-
 8 files changed, 175 insertions(+), 76 deletions(-)
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/54976691
  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
JS
  1. Note that if folks agree to this - I'm thinking of the deprecation removals and the scrambling this may cause as a reason folks may not - I'll probably - after LGTMS today TBR early tomorrow am with final CHANGELOG edits - today is somewhat active on the changes hitting master front.
  2. 
      
AR
  1. 
      
  2. src/python/pants/base/target.py (Diff revision 1)
     
     

    I was thinking about this earlier (well, not this specficially, but removing the pants() lambda). What if instead of killing this code, the pants 0.0.30 release made this deprecated fatal. In that way, we would generate a nice error message for anyone that still has old BUILD files / tasks that are interacting with pants.

    Then, once it has been fatal for a release or two, kill the code?

    1. This change _does_ make it fatal since the method is removed.  If you are proposing a generic 2-phase deprecation system, I'll insist you provide details on exactly how you want to accomplish this.  The current system is only 1-step, that step can be however many strides you wish by setting a version N steps past the current.  Additionally - the current system is nice in that you get a CI build failure if you don't remove the deprecated item as promised!
    2. The reasonable requests seem to me to be:
      + [Nack] please don't release yet - we have X days of work to do before we can clean up our deprecated usages
      + [Qualified nack] please move the deprecation for X forward to version Y to buy us time to handle X
    3. I'm marking this issue as dropped since another tweep Acked - presumably you all talk to each other!
  3. 
      
PA
  1. Looks good, but I just want to make sure that https://rbcommons.com/s/twitter/r/1938/ also makes it in. It's a very important bug fix.

    1. Will do if I get no Nacks on the whole release.
    2. That fix is in master and this CHANGELOG so good to go.
  2. 
      
MA
  1. As of 8aa92e2294f757f44c7241be0d7efc9326839c88, Nick added a 0.0.30 deprecation to ScmPublish, so I have this failing on current OSS master.

    I also am getting a failure in some Android tests, but I don't think that has to delay publishing if I haven't found the fix.

    1. OK - 8aa92e2294f757f44c7241be0d7efc9326839c88 is in this RB's parent chain, so the CI shard that "compiles" python code should fail nicely.
    2. As you pointed out: https://travis-ci.org/pantsbuild/pants/jobs/54949085
      ```console
      ...
        File "/home/travis/build/pantsbuild/pants/src/python/pants/backend/core/tasks/scm_publish.py", line 216, in ScmPublish
          @deprecated('0.0.30', hint_message='Use ScmPublishMixin instead.')
        File "/home/travis/build/pantsbuild/pants/src/python/pants/base/deprecated.py", line 86, in deprecated
          check_deprecated_semver(removal_version)
        File "/home/travis/build/pantsbuild/pants/src/python/pants/base/deprecated.py", line 62, in check_deprecated_semver
          'version of {} - given {}'.format(VERSION, removal_version))
      Exception message: The removal version must be greater than the current pants version of 0.0.30 - given 0.0.30
      ...
      ```
      
      Fix coming.
    3. As for android tests - I repro locally, but the surface sheen indicates issues related to Stu's jvm compile changes/your attempted fix for android libs:

                           ==================== FAILURES ====================
                           __ AaptBuilderIntegrationTest.test_aapt_bundle ___
      
                           self = <pants_test.android.tasks.test_aapt_builder_integration.AaptBuilderIntegrationTest testMethod=test_aapt_bundle>
      
                               @pytest.mark.skipif('not AaptBuilderIntegrationTest.tools',
                                                   reason='Android integration test requires tools {0!r} '
                                                          'and ANDROID_HOME set in path.'.format(TOOLS))
                               def test_aapt_bundle(self):
                           >     self.bundle_test(AndroidIntegrationTest.TEST_TARGET)
      
                           tests/python/pants_test/android/tasks/test_aapt_builder_integration.py:36: 
                           _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                           tests/python/pants_test/android/tasks/test_aapt_builder_integration.py:40: in bundle_test
                               self.assert_success(pants_run)
      ...
                           E      18:43:44 00:01   [compile]
                           E      18:43:44 00:01     [compile]
                           E      18:43:44 00:01     [jvm]
                           E      18:43:44 00:01       [jvm-compilers]
                           E      18:43:44 00:01         [find-deleted-sources]
                           E                           Invalidated 2 targets.
                           E      FAILURE: Classpath entry /opt/android-sdk-linux/platforms/android-19/android.jar is located outside the buildroot.
                           E      
                           E      
                           E                     Waiting for background workers to finish.
                           E                     FAILURE
      

      Digging a bit more presenty...

    4. Yeah, I saw the same thing. I may have missed something in a later revision. I will fix it tonight.

    5. You know what this is? The ivy cache. I even made a note of it in that fix...Delete the relevant ivy cache for the example project and this should work. I will verify this when I get home.

    6. You are correct sir:

      jsirois@gill ~/dev-jsirois-pants4 (jsirois/release/prep_0.0.30) $ find ~/.ivy2/pants -type d | grep android
      /home/jsirois/.ivy2/pants/com.google/android
      jsirois@gill ~/dev-jsirois-pants4 (jsirois/release/prep_0.0.30) $ rm -rf /home/jsirois/.ivy2/pants/com.google/android
      jsirois@gill ~/dev-jsirois-pants4 (jsirois/release/prep_0.0.30) $ pants.dev test tests/python/pants_test/android/tasks/:aapt_builder_integration
      ...
      19:12:16 00:00   [test]
      19:12:16 00:00     [run_prep_command]
      19:12:16 00:00     [test]
      19:12:16 00:00     [pytest]
      19:12:16 00:00       [run]
                           ============== test session starts ===============
                           platform linux2 -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4
                           plugins: cov, timeout
                           collected 1 items 
      
                           tests/python/pants_test/android/tasks/test_aapt_builder_integration.py .
      
                           ============ 1 passed in 5.52 seconds ============
      
      19:12:22 00:06     [junit]
      19:12:22 00:06     [specs]
                     SUCCESS
      

      I won't block on this then.

  2. 
      
ST
  1. Ship It!
  2. 
      
JS
ZU
  1. 
      
  2. build-support/bin/release.sh (Diff revision 2)
     
     

    It doesn't matter but I'm suprised you didn't put && inside the [[ ]]

    1. Me too! - fixed.
  3. 
      
MA
  1. Ship It!
  2. 
      
JS
JS
JS
  1. Thanks folks - submitted @ https://github.com/pantsbuild/pants/commit/4362756c33b5585230b6dc6d256a81229dde1ef0 and released: https://pypi.python.org/pypi/pantsbuild.pants/0.0.30
    The rst render of the changelog is still borked on pypi so I'll need to dig on that next session.
  2. 
      
JS
Review request changed

Status: Closed (submitted)

IT
  1. Ship It!
  2. 
      
Loading...