Add flags to idea and eclipse goals to exclude pulling in sources and javadoc via ivy.

Review Request #1939 — Created March 18, 2015 and submitted

zundel
pants
zundel/idea-without-sources-javadoc
1282
d8dd084...
pants-reviews
fkorotkov, patricklaw

Add flags to idea and eclipse goals to exclude pulling in sources and javadoc via ivy.
Make sure that invalidation considers the list of confs by integrating it into the fingerprint strategy.

Updated idea integration tests.

  • 0
  • 0
  • 3
  • 0
  • 3
Description From Last Updated
FK
  1. 
      
  2. should it be True by default?

    1. Yes, next update fixes it.

  3. 
      
PA
  1. General thrust of the change looks fine, but there are necessary changes.

    1. Sorry, this patch wasn't really ready when I posted it. Thanks for the feedback.

      I was rushing out the door and wanted to put this up because Fedor was potentially about to run into this bug when including sources and javadoc confs in the IDE.

  2. Looks like a missing comma

  3. It's extremely important that this be mixed into the __hash__ and __eq__ definitions for this class to prevent caching issues. See JvmFingerprintStrategy for reference.

  4. 
      
ZU
PA
  1. Ship It!
  2. 
      
ZU
ZU
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks for the reviews. Commit aca4aab

Loading...