Move AptCompile to its own file

Review Request #1935 - Created March 17, 2015 and submitted

Information
Stu Hood
pants
dc7e5d0...
Reviewers
pants-reviews
jsirois, nhoward_tw, zundel

Extract AptCompile into the java package, and move annotation-processor specific logic there.

https://github.com/pantsbuild/pants/pull/1276

John Sirois
Stu Hood
Stu Hood
Review request changed

Status: Closed (submitted)

Eric Ayers

   

The 'apt' nomenclature is getting to be antiquated. The separate 'apt' tool is deprecated in Java 7 in favor of just invoking javac with different arguments. Maybe we should start calling this work 'compile-annotation-processors' and also have a 'run-annotation-processors' step?

I know this is code is just moved from java_compile.py.

I was looking at it closely because we occasionally run into problems that only a clean-all will solve. The last one I looked at was a problem compiling the annotation processor code itself, I don't think its related to this.

However I was looking at this stanza and thinking that maybe the order of running processors is significant and this should be an OrderedSet. I'll save this for a follow on.

nit: change to .format()

Loading...