Move JVM debug config functionality to the new options system.

Review Request #1924 — Created March 16, 2015 and submitted

benjyw
pants
8920821...
pants-reviews
ity, jsirois, patricklaw, zundel
Temporarily requires configuring this for each JvmTask subtask separetely,
which we mitigage by putting the config in the DEFAULT section (even though
it's JVM-specific and the option names don't mention that).

Soon 'JVM' will be a subsystem, and this problem will go away.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/54603023

Manual testing that options have the desired effect.

ZU
  1. The whole reason for the jvm_debug_config.py was to allow the IDE to share these debug options. I should have done what you just did when I decoupled idea from the debug_port option. Maybe when there is a subsystem we could re-hookup reading the debug_port from the same config value.

    1. Yeah, the first subsystem I will create will be "JVM", and hopefully it'll be easy to grab its config for things like idea_gen and the intellij plugin.

  2. 
      
JS
  1. 
      
  2. The wrapping [] can go.
  3. 
      
BE
JS
  1. Ship It!
  2. 
      
BE
BE
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as 1d38a245308c2941b9e4df92fdd61a11e08daa76.

IT
  1. Ship It!
  2. 
      
Loading...