Trying to clarify how to contribute docs.

Review Request #1922 — Created March 15, 2015 and submitted

gigamonkey
pants
gigamonkey/contrib_docs
1261
a5ff71a...
pants-reviews
lahosken

Fix typo.



  • 0
  • 0
  • 1
  • 1
  • 2
Description From Last Updated
AR
  1. LGTM, modolo what's below

  2. AFAIK this is not required -- we don't allow pushing branches to pantsbuild/pants origin any more.

    1. It was in the docs before. Was it wrong? I assume this means the branch where you've pushed your change for the pull request, e.g. this one is at gigamonkeys/contrib_docs.

    2. Ah, okay, that makes some sense. However, without information on your github fork, I think this is fairly useless. Maybe instead of including the branchname, we should tell people to paste in a link to their branch on their github fork? I think that would be more useful, because then I could click on it.

      Or maybe we could have them link to the pull request.

  3. 
      
GI
ZU
  1. Could you add Larry Hosken to the review?

  2. 
      
JS
  1. Also - it looks like the email pipeline is still borked.  Although you switched RB to send as not@twitter.com, your pants-reviews@googlegroups.com subscription is still via the twitter email address.
  2. 
      
GI
IT
  1. Ship It!
  2. 
      
GI
Review request changed

Status: Closed (submitted)

Change Summary:

submitted @ 40b5bcd9a8ddb4f0c9d92e83dddc9ba086bfa7a8

Loading...