walk synthetic targets dependencies when constructing context.target()

Review Request #1914 - Created March 13, 2015 and submitted

Information
Nick Howard (Twitter)
pants
1255
197c464...
Reviewers
pants-reviews
dturner-tw, ity, jsirois, tejal

A recent change made it so that synthetic targets dependencies aren't traversed which caused their 3rdparty deps to be not added to the classpath in certain cases. This caused compilation errors. This patch retains the derivation checks from the previous one, but expands the synthetic targets after determining which ones are needed.

RB of the patch that changed the ordering which caused the issue: https://rbcommons.com/s/twitter/r/1863/

wrote unit test, verified existing behavior. ran context tests. CI baking at https://travis-ci.org/pantsbuild/pants/builds/54317247

Nick Howard (Twitter)
Tejal Desai
Ity Kaul
Patrick Lawson
David Turner
Patrick Lawson
Nick Howard (Twitter)
Review request changed

Status: Closed (submitted)

Change Summary:

submitted as 8c4190ca956a83f3286bc0d104041e94d53eaa59

Loading...