Added a python helper for check_header.sh in git pre-commit script.

Review Request #1910 - Created March 12, 2015 and submitted

Information
Eric Ayers
pants
1250
4f1ec21...
Reviewers
pants-reviews
benjyw, dturner-tw, jsirois, lahosken

On my box this speeds up the header check from 5 seconds to a little over 1 second.

 build-support/bin/check_header.sh        | 46 ++--------------------------------------------
 build-support/bin/check_header_helper.py | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 72 insertions(+), 44 deletions(-)

~/Src/Pants zundel/cheader * git commit -a
Checking packages
Checking imports
Checking headers
ERROR: All .py files other than __init__.py should start with the following header:

# coding=utf-8
# Copyright YYYY Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).

from __future__ import (absolute_import, division, generators, nested_scopes, print_function,
                        unicode_literals, with_statement)


---
The following 1 file(s) do not conform:
  src/grody.py
John Sirois
Eric Ayers
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks for the review John. Commit fa44550

Loading...