docs: some twitter/commons cleanup; pingpong->hello

Review Request #191 — Created April 8, 2014 and submitted

lahosken
pants
pants-reviews
benjyw
There were some mentions of twitter/commons that became pants
There were some "../.." that became ".."

Use examples/hello as sample code instead of examples/pingpong. Pingpong's a great program to show off twitter/commons; it's not so great for a simple Pants example
Doc generation now has many fewer failed-include warnings, yay
LA
BE
  1. Ship It!
    1. Do you plan to delete pingpong entirely? If so, let's add a third-party jar dep to hello, so we can demo that?
    2. > Do you plan to delete pingpong entirely?
      
      Yeah. (Or if folks want to keep pingpong around for testing, I at least want the docs to stop presenting it as our simple example.)
      
      > If so, let's add a third-party jar dep to hello, so we can demo that?
      
      What do you think of  
      tests/java/com/pants/examples/hello/greet/'s dependency on 3rdparty:junit
      as that demo? (Since I'm a Northern Californian, I should point out:
      My question is a question, not a passive-aggressive statement.)
      It's not a lib; it might be nicer if it were a lib. On the plus side, without that dep, the code didn't build, so nobody can accuse me of shoehorn-ing in a gratuitous dep :-)
      
      If the answer is "Eh... kinda weak, would be nicer to have something in the lib" then suggestions are welcome. My Java knowledge is puny.
    3. > Maybe 3rdparty:util-core, and find some basic code in there to call?
      
      SGTM
  2. 
      
LA
LA
Review request changed

Status: Closed (submitted)

Loading...