Allow multiple ivy artifacts distinguished only by classifier.

Review Request #1905 — Created March 12, 2015 and submitted

dturner-tw
pants
ca7b6be...
pants-reviews
ity, jinfeng, jsirois, zundel
Allow multiple ivy artifacts distinguished only by classifier.

New test is red before, green after.

https://travis-ci.org/pantsbuild/pants/builds/54039178 CI running

ZU
  1. Ship It!
  2. 
      
JS
  1. 
      
  2. The error messages on conflicting forces in _resolve_conflict could stand updating now since it will be unclear where the conflict comes from if someone defines jars just differing in classifiers but with forces in each.
    1. Those won't conflict; _resolve_conflict is only called when two things have the same coordinates, including (now) classifiers.

    2. I was unclear - the error message won't indicate the classifier on a force conflict, so the user will not know if they had a conflicting force on ('com.twitter', 'finagle', None) or (''com.twitter', 'finagle', 'sources') assuming they have each as explicit deps in their BUILD graph and in various places they also force each.
  3. 
      
IT
  1. lgtm!

  2. 
      
DT
Review request changed

Status: Closed (submitted)

Loading...