Fish Trophy

benjyw got a fish trophy!

Make rglobs follow symlinked directories by default.

Review Request #1881 — Created March 7, 2015 and submitted

benjyw
pants
9da5837...
pants-reviews
dturner-tw, jsirois, patricklaw, stuhood, zundel

It seems unintuitive that it doesn't, and this has in fact led
to problems in Foursquare's codebase.

Feel free to push back if you think this should not be the default.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/53424050

JS
  1. 
      
  2. I've stated my objections to this defult elsewhere, but the objections aside, presumably you agree rglobs and zglobs should have a uniform default.
  3. Its confusing to use bare asserts when you're testing in a unittest.TestCase class.  Its unclear whether the py.test juicing of assert is in play or not.  I think its best to stick to self.assertXXX or else switch a pure py.test style top-level function test everywhere in the file.
  4. 
      
PA
  1. Ship It!
  2. 
      
ZU
  1. Ship It!
  2. 
      
DT
  1. I agree that this ought to be the default.

  2. 
      
BE
BE
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as 85eba05e0bfbf3a5f82a16fb2613f96373631efd.

Loading...