Thanks for doing this, it mostly looks good to me. The resources thing is a nit (and totally optional), but I'd like to see if you can use
assertMultilineEqualwhen comparing the templates -- I think that will give a better error message.
Alternatively, you can show the error message that results in a mis-match w/ your current code. If that makes it obvious what's wrong, then I'm cool with it.
It seems like it should be possible to tag the resource dir on the
python_tests()target in the
But I'm not seeing an example of how to access the resources from the python side. I see some stuff in the science repo, but I'm not sure if they're actually using the resource dir supplied by pants.
I think if you used something like
Then we'd get nice error messages in the future, when we change the template but forget to change the test. My understanding is that it will give you a visual diff, highlighting what part of the golden template that needs to be changed.
Add jar Publish integration tests to test the generated pom and ivy.xml files.
Review Request #1879 — Created March 6, 2015 and submitted
|areitz, ity, jsirois, stuhood|
Add test to jar publish to test the contents of generated pom file and ivy.xml file
This is in preparation to change JarPublish task to publish extra products as a separate artifact with its own pom
You will seeing a patch and tests for the same soon.
More context here->
./pants test.pytest tests/python/pants_test/tasks:jar_publish_integration is green
Addressed code review changes
Looks awesome, thanks!