Handle --print-exception-stacktrace and --version more elegantly.

Review Request #1871 — Created March 6, 2015 and submitted

benjyw
pants
1dc34bd...
pants-reviews
jinfeng, jsirois, patricklaw, zundel
- --print-exception-stacktrace is now a regular global option.
  Previously it was registered as one, but not actually used.
  Instead, pants_exe.py special-cased it by looking for it on the
  cmd line. This meant that it couldn't be set in config, for example.

- --version is now special-cased in the options parser, using the same
  mechanism as --help. This makes sense as --version is very similar
  to --help in spirit, and isn't really an option (you'd never want
  to set it in config, for example).

- --log-exit support was removed, since it doesn't currently work, and
  is completely unnecessary anyway.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/53283617

Manually tried the various flags.

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
BE
PA
  1. 
      
  2. I don't think there's ever a correct use of str in polyglot python. Maybe six's text_type? Though I just noticed that this is a test, so maybe it isn't such a big deal.

    1. I cargo-culted that from above, but it turns out neither are needed. Removed.

  3. 
      
BE
ZU
  1. Ship It!
  2. 
      
BE
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as a814168ccccb5247e97de6d95edf1f4dfa8bf376.

Loading...