Add Scm.add, change publish to add pushdb explicitly, move scm publish around

Review Request #1868 - Created March 5, 2015 and submitted

Information
Nick Howard (Twitter)
pants
1206
a112b28...
Reviewers
pants-reviews
areitz, jsirois, tejal
If a provided artifact hasn't been pushed before, the pushdb file for it may not be tracked by git yet.
This changes publishing so that the pushdb will be added before committing, ensuring that the commit will contain the pushdb changes.
It also moves the scm publish steps into ScmPublish so that JarPublish needs to know less about publishing to scm.

ran build-support/bin/ci.sh, travis baking https://travis-ci.org/pantsbuild/pants/builds/53237399

Issues

  • 0
  • 3
  • 0
  • 3
Description From Last Updated
John Sirois
Andy Reitz
Tejal Desai
Tejal Desai
Nick Howard (Twitter)
Stu Hood
Andy Reitz
Nick Howard (Twitter)
John Sirois
Nick Howard (Twitter)
Nick Howard (Twitter)
Nick Howard (Twitter)
Review request changed

Status: Closed (submitted)

Change Summary:

submitted at 8aa92e2294f757f44c7241be0d7efc9326839c88

Tejal Desai

Shipit for the diff 6:
one line change in scm_publish => scm.add.

Mateo Rodriguez

   

traceback is not available at this point, never imported.

  1. good catch. rb incoming.

Mateo Rodriguez

   

The attempts kwarg is unused in the actual function.

  1. same as above. Thanks!

  2. Sure, sorry to drop them in separate reviews, I saw them as I looked at the deprecation changes. If you are fixing up, the ident is off by two spaces on line 157, although obvs. a trivial issue (and not yours, either).

Loading...