Fix classifier to be what was from config. If not present in config then use extension and override name to make it unique

Review Request #1857 — Created March 4, 2015 and submitted

tejal
pants
pants-reviews
areitz, benjyw, ity, patricklaw, zundel
Fix classifier to be what was from config. If not present in config then use extension and override name to make it unique

yes.
Rab jar publish tests manually.
https://travis-ci.org/pantsbuild/pants/builds/52984126

BE
  1. 
      
  2. This can just be

    classifier or '%s-%s'.format(override_name, extension)

    Also, please correct to single quotes, since you're already editing the line.

  3. 
      
BE
  1. After addressing my minor comment.

  2. 
      
TE
BE
  1. Ship It!
  2. 
      
TE
TE
IT
  1. Ship It!
  2. 
      
JS
  1. This fix is needed to honor hypothetical artifact consumers who resolve via ivy.xmls and not poms, but I am curious why Twitter needs this fix - presumably they don't actually resolve via ivy.xmls.
    1. That's correct. But we think we're going to start using ivy.xml's, in at least one repo outside of source.

    2. OMG
  2. It would be great to follow up with an integration test - better to land it with this change.  The infra for publish_extra testing was already established: https://github.com/pantsbuild/pants/blob/master/tests/python/pants_test/tasks/test_jar_publish_integration.py
    1. In light of Andy's comment it seems to me there is no rush here so landing the test now would be excellent.
    2. Actually we are tying many ways to fix publishing. One of them is just fixing this.
      I aready submitted this change since we have a new pex release scheduled tomorrow.
      I might end up changing code and will add tests for publishing extra confs.

  3. 
      
TE
Review request changed

Status: Closed (submitted)

Loading...