Modernize the protobuf and wire task tests

Review Request #1854 - Created March 3, 2015 and submitted

Information
Eric Ayers
pants
zundel/modernize-proto-and-wire-task-tests
1194
773e071...
Reviewers
pants-reviews
benjyw, jsirois
  • Get rid of odd inheritance in WireGen test
  • Cleanup BUILD deps
  • Inherit from TaskTestBase instead of TaskTest
  • Refactor alias_groups() to use shortcuts directly from register.py
  • Use self.create_file() helper function
  • Refactor some top level symbols back into the task objects
  • Add test of _calculate_sources that uses the instantiated task
  • Add test for check_duplicate_conflicting_protos

 src/python/pants/backend/codegen/tasks/protobuf_gen.py             |  45 +++++++++---------
 src/python/pants/backend/codegen/tasks/wire_gen.py                 |  46 +++++++++---------
 tests/python/pants_test/backend/codegen/tasks/BUILD                |  13 ++++--
 tests/python/pants_test/backend/codegen/tasks/test_protobuf_gen.py | 262 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------
 tests/python/pants_test/backend/codegen/tasks/test_wire_gen.py     |  66 ++++++++++++++++++++++----
 5 files changed, 288 insertions(+), 144 deletions(-)

CI is running @ https://travis-ci.org/pantsbuild/pants/builds/52902539

Issues

  • 0
  • 1
  • 2
  • 3
Description From Last Updated
Eric Ayers
Benjy Weinberger
Eric Ayers
Benjy Weinberger
Eric Ayers
Benjy Weinberger
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks for the review Benjy. Commit d97b02c

Loading...