Fixup pants binary constraints.

Review Request #185 — Created April 8, 2014 and submitted

jsirois
pants
jsirois/ci
36
pants-reviews
benjyw, patricklaw, wickman
More should be done here as called out in TODO's.  In particular:
1.) The py & build commands should use the interpreter constraints from a python_binary when present and in the absence of flag overrides.
2.) debatable: The PythonInterpreterCache could stand a refactor to be stateless, ie: have setup return a new object with the interpreter property and the matches method.

commit f22b7feb90c5806ad9212a0d025605369c6f4a8c
Author: John Sirois <jsirois@twitter.com>
Date:   Sat Apr 5 09:52:52 2014 -0600

    Fixup pants binary constraints.
    
    Limit compatibility to 2.6 through 2.7 and 3.3+ to avoid issues
    with 3.0 through 3.2 not supporting unicode literals.  This now
    explicitly runs afoul of pants import headers.

 build-support/bin/ci.sh                      | 16 ++++++--
 pants                                        |  4 +-
 src/python/pants/bin/BUILD                   |  4 ++
 src/python/pants/commands/build.py           | 14 ++++---
 src/python/pants/commands/py.py              | 14 ++++---
 src/python/pants/python/interpreter_cache.py | 99 +++++++++++++++++++++++++++++++++-----------------
 src/python/pants/tasks/python/setup.py       |  2 +-
 7 files changed, 105 insertions(+), 48 deletions(-)
Locally:
$ git clean -fdx && ./build-support/python/clean.sh && ./build-support/bin/ci.sh

Travis mostly green - re-running: https://travis-ci.org/pantsbuild/pants/builds/22542433
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
JS
  1. And green for real now: https://travis-ci.org/pantsbuild/pants/builds/22542433
  2. 
      
TR
  1. Ship It!
  2. 
      
PA
  1. Ship It!
  2. 
      
WI
  1. 
      
  2. src/python/pants/bin/BUILD (Diff revision 1)
     
     
    why the bytes?  i consider the necessity of this a bug somewhere else.
    1. Yes - its a bug down in commons/python, I'll file an issue and note it here in a TODO, I'd prefer to unblock from commons.
    2. Filed and TODO'd: https://github.com/twitter/commons/issues/279
  3. 
      
BE
  1. What about the interpreter pants shells out to when you run something with ./pants py? We've had issues with that too.
    1. 1 step at a time, this gets us green and also plumbs -i for real to the py subcommand - so you can always use that.
      
  2. 
      
JS
WI
  1. Ship It!
  2. 
      
JS
JS
  1. Thanks folks - merged.  May Travis go green.
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...