Add pants_bootstradir and pants_configdir to options bootstrapper.

Review Request #1835 — Created Feb. 26, 2015 and submitted

mateor
pants
7d19860...
pants-reviews
benjyw, jsirois, zundel

Make these values available to all classes plumbed with
the options system. There are two OSS places that directly use
pantsboostrapdir: binary_utils and in the ivy boostrapper.
So as config access is removed from those classes, then
they can convert to getting the pants_bootstrapdir from the options
as well.

Removed the expanduser call from the ivy bootstrapper as
it is now redundant. The expanduser happens in the
build_environment.get_cachedir() call that sets
pants_bootstrapdir globally.

Travis is baking (and it is gonna be awhile...): https://travis-ci.org/pantsbuild/pants/builds/52220006

JS
  1. 
      
  2. These should be marked as advanced=True options.

    1. Good, I am glad that is appropriate here. I will update.

  3. 
      
MA
ZU
  1. Ship It!
  2. 
      
MA
  1. Thanks - in master @ https://github.com/pantsbuild/pants/commit/4b30e60c275ecfeedfb64100bf28c9107ef68ccb

  2. 
      
MA
Review request changed

Status: Closed (submitted)

Loading...