fix stupid use of string for variable
Review Request #1824 - Created Feb. 24, 2015 and submitted
|benjyw, jsirois, zundel|
This wasn't caught because the tests weren't run because the test file was misnamed; this RB also fixes the name of the test file.
The tests would sometimes fail because jmake would miss an update, and a fix for that is included here. There's also a fix for a (probably harmless but annoying) warning message.
Also, manual testing along with
This is a good find. I've got a couple comments.
I'm not asking for a fix in this patch, but I'm pretty sure that a null check after a new will always fail. Maybe we should remove it?
I'm not sure, but I think this was cls < src because the code above it is doing the same thing but with the operands reversed: !(src <= cls). If you change it, they won't be equivalent.
Maybe we should change line 706 and 716 to compare in the same order. Then their relationship would be clearer.