Replace config use in RunTracker with options.

Review Request #1823 — Created Feb. 24, 2015 and submitted

benjyw
pants
63e7036...
pants-reviews
jsirois, zundel
- RunTracker now registers its options.
- This is the first case we have of non-task, non-global options.
- The current implementation special-cases RunTracker, and is temporary.
- In the near future it will be replaced with a 'Subsystem' abstraction.
- But for now this is useful for kicking the tires.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/51924498

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
JS
  1. 
      
  2. Are these advanced?  They sound like things you'd only ever reasonably re-configure in pants.ini unless you were hacking on the RunServer itself - and that's advanced.
    1. You're right, these should be advanced. Fixed.

  3. src/python/pants/goal/run_tracker.py (Diff revision 1)
     
     
    These all seem advanced to me.  In general I think any non-global, non-task option is going to be advanced and should be omitted from normal help.
    1. Ditto. These are all advanced now.

  4. 
      
ZU
  1. 
      
  2. src/python/pants/bin/goal_runner.py (Diff revision 1)
     
     

    add TODO() with your desired followon change to get rid of this one off

    1. Good idea. Done.

  3. 
      
BE
JS
  1. Ship It!
  2. 
      
BE
  1. Submitted as ddafa1cdeeac0c947a33d654502fe90317f1a343.

  2. 
      
BE
Review request changed

Status: Closed (submitted)

Loading...