Convert config-only options in goal idea and eclipse to use new options format

Review Request #1805 — Created Feb. 20, 2015 and submitted

zundel
pants
zundel/idea-advanced-args
1142
275c979...
pants-reviews
benjyw, tejal

Convert config-only options in goal idea and eclipse to use new options format

Ran against migrate_config against pants.ini before and after upgrade.
CI passed at: https://travis-ci.org/pantsbuild/pants/builds/51529403

ZU
BE
  1. Thanks for tackling this.

  2. Which reminds me that it's on me to figure out a sensible way to register options at the goal level, so that tasks can inherit them.

    Of course that would only help here if we also registered idea and eclipse under a shared 'ide' goal, which might be more disruptive than we want to be.

    1. I had some mixed feelings about changing this. On the one hand, it stinks to have to copy things to two places. On the other hand, as an end user it was confusing to try to figure out where to set things.

  3. 
      
TE
  1. Looks good to me.

  2. 
      
ZU
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks Benjy & Tejal! Submitted as f2b5eea

Loading...