Disallow --no- on the name of boolean flags, refactor existing ones

Review Request #1799 - Created Feb. 20, 2015 and submitted

Information
Eric Ayers
pants
zundel/fix-no-colors
1133
444940c...
Reviewers
pants-reviews
benjyw, fkorotkov, jsirois

This came out of an issue with the IntelliJ plugin. See https://github.com/pantsbuild/intellij-pants-plugin/issues/34

  • Rename --no-colors to --colors and invert the logic that checks it.
  • --no-locks does not seem to be implemented anywhere. Removed this flag.
  • Fixed up removing color output for java compilation.
  • Added a deprecation message for --color in specs_run
  • Passing --no-color to running python tests seems to work - I think this option is just passed through to pytest but I was unable to find the exact mechanism on how this works.

devpants compile examples/src/java/com/pants/examples/hello/main --no-colors

Note that ./pants clean-all --no-colors does not work, but ./pants --no-colors clean-all does.

Benjy Weinberger
Eric Ayers
Benjy Weinberger
John Sirois
Eric Ayers
Eric Ayers
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks for the reviews. Submitted at 6453c0f

Loading...