Create a directory with no write perms for TestAndroidConfigUtil.

Review Request #1796 — Created Feb. 19, 2015 and submitted

mateor
pants
b04ed06...
jinfeng, jsirois
The original test assumed we would have no write permissions outside
of home, which turned out not to be a safe assumption.

I added the IOError to the exception catch in AndroidConfigUtil.
The OSError is raised from the safe_open, if there is no
permission to make dirs. The IOError is for cases where the
directories exist but pants does not have permission to write there.

PANTS_DEV=1 ./pants test tests/python/pants_test/android::
Travis passed: https://travis-ci.org/pantsbuild/pants/builds/51419786

DT
  1. 
      
  2. nit: s/File name and location for/Full path to/

  3. 
      
MA
JI
  1. Ship It!
  2. 
      
TE
  1. Ship It!
  2. 
      
MA
  1. Thanks - in master @ https://github.com/pantsbuild/pants/commit/b5b1bab3aeb78626dd205d70b6ade571192d8c56

  2. 
      
MA
Review request changed

Status: Closed (submitted)

JS
  1. Thanks for the robustification.
  2. 
      
Loading...