Take care of stale pidfiles for pants server

Review Request #1791 — Created Feb. 18, 2015 and submitted

zundel
pants
zundel/fix-pants-server-stalepid
1122, 1124
3723b52...
pants-reviews
benjyw, davidt, patricklaw

Use psutil to detect a pidfile for a process that is no longer active.

An even more robust algorithm would check the commandline for some kind of fingerprint of the right process like we do in the nailgun task executor.

Repeated invocations of:

./pants server
kill <PID>
BE
  1. We should probably look into unifying this and the nailgun mechanism into some sort of "run a daemon" lib, at some point.

  2. 
      
DA
  1. Ship It!
  2. 
      
ZU
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks for the reviews Benjy & David. Added a TODO with Benjy's nailgun comment and submitted as commit f645e25db6a5ff19041a2bd9e8f5a32dde90a12c

NH
  1. Thanks so much for this!

  2. 
      
Loading...