Fixup nailgun detection under unicode literals.

Review Request #179 — Created April 7, 2014 and submitted — Latest diff uploaded

jsirois
pants
jsirois/jvm/nailgun
21
pants-reviews
benjyw, ity, patricklaw
commit 83924ca1b04a7320548de0ac37633d24c94c9ab4
Author: John Sirois <jsirois@twitter.com>
Date:   Mon Apr 7 09:31:03 2014 -0600

    Fixup nailgun detection under unicode literals.
    
    Unicode literals in the NailgunExecutor command line
    did not interact well with psutil - use byte strings
    for these.
    
    Also kill conditional psutil related code since its
    now always available.
    
    Finally - fixup the ci script jvm target.

 build-support/bin/ci.sh                   |   3 +-
 src/python/pants/java/nailgun_executor.py | 132 +++++++++++++++++++++++++-------------------------
 src/python/pants/tasks/nailgun_task.py    |   2 +-
 3 files changed, 67 insertions(+), 70 deletions(-)
Now with real compile and tests
$ ./build-support/bin/ci.sh
...
[== Running jvm tests ==]


09:35:14 00:00 [main]
               See a report at: http://localhost:45431/run/pants_run_2014_04_07_09_35_14_595
09:35:14 00:00   [setup]
09:35:14 00:00     [bootstrap]
09:35:14 00:00     [parse]
09:35:14 00:00   [bootstrap]
09:35:14 00:00     [bootstrap-jvm-tools]
09:35:14 00:00   [gen]
09:35:14 00:00     [thrift]
                   Invalidated 2 targets containing 2 source files.
                   Generating thrift for src/thrift/com/pants/examples/precipitation/precipitation.thrift
                   
09:35:14 00:00     [scrooge]
09:35:14 00:00     [protoc]
09:35:14 00:00     [antlr]
09:35:14 00:00   [check-exclusives]
09:35:14 00:00     [check-exclusives]
09:35:14 00:00   [resolve]
09:35:14 00:00     [ivy]
09:35:14 00:00       [bootstrap-nailgun]
                   Invalidated 37 targets.
09:35:15 00:01       [ivy-resolve]
09:35:15 00:01         [ivy]
09:35:17 00:03   [compile]
09:35:17 00:03     [jvm]
09:35:17 00:03       [java]
                     Invalidated 9 targets containing 9 source files.
09:35:17 00:03         [find-deleted-sources]
                     Compiling a partition containing 9 sources in 9 targets.
09:35:17 00:03         [compile]
09:35:17 00:03           [bootstrap-jmake]
09:35:18 00:04           [bootstrap-java-compiler]
09:35:18 00:04           [jmake]
                         Jmake version 1.3.7-3
                         warning: bootstrap class path not set in conjunction with -source 1.6
                         Apr 07, 2014 9:35:19 AM com.twitter.common.args.apt.Configuration load
                         INFO: Loading @CmdLine config from: [jar:file:/home/jsirois/dev/3rdparty/pantsbuild-pants/.pants.d/classpath/jars/com.twitter.common/application-module-http/jars/application-module-http-0.0.61.jar!/com/twitter/common/args/apt/cmdline.arg.info.txt.1, jar:file:/home/jsirois/dev/3rdparty/pantsbuild-pants/.pants.d/classpath/jars/com.twitter.common/application/jars/application-0.0.72.jar!/com/twitter/common/args/apt/cmdline.arg.info.txt.1, jar:file:/home/jsirois/dev/3rdparty/pantsbuild-pants/.pants.d/classpath/jars/com.twitter.common/application-module-log/jars/application-module-log-0.0.55.jar!/com/twitter/common/args/apt/cmdline.arg.info.txt.1, jar:file:/home/jsirois/dev/3rdparty/pantsbuild-pants/.pants.d/classpath/jars/com.twitter.common/logging/jars/logging-0.0.59.jar!/com/twitter/common/args/apt/cmdline.arg.info.txt.1, jar:file:/home/jsirois/dev/3rdparty/pantsbuild-pants/.pants.d/classpath/jars/com.twitter.common/application-module-stats/jars/application-module-stats-0.0.43.jar!/com/twitter/common/args/apt/cmdline.arg.info.txt.1, jar:file:/home/jsirois/dev/3rdparty/pantsbuild-pants/.pants.d/classpath/jars/com.twitter.common/args/jars/args-0.2.8.jar!/com/twitter/common/args/apt/cmdline.arg.info.txt.1]
                         note: Writing file:/home/jsirois/dev/3rdparty/pantsbuild-pants/.pants.d/javac/classes/com/twitter/common/args/apt/cmdline.arg.info.txt.2
                         Writing project database...  Done.
                         
09:35:20 00:06         [find-missing-dependencies]
09:35:20 00:06           [map_sources]
09:35:20 00:06           [map_classes]
09:35:20 00:06           [map_jars]
09:35:20 00:06           [scan_deps]
09:35:20 00:06   [resources]
09:35:20 00:06     [prepare]
09:35:20 00:06   [test]
09:35:20 00:06     [junit]
09:35:20 00:06       [bootstrap-junit]
09:35:21 00:07       [run]
                     .....
                     Time: 0.138
                     
                     OK (5 tests)
                     
                     
...
Loading...