Fixup JarPublish changelog rendering.

Review Request #1787 - Created Feb. 18, 2015 and submitted

Information
John Sirois
pants
jsirois/jar_publish/non_tty_non_ascii_changelog_fix
1119
3d39a24...
Reviewers
pants-reviews
dturner-tw, zundel
Previously, without a TTY, JarPublish would fail to render changelogs
with non-ascii characters.  Explicitly handle this case.

 src/python/pants/backend/jvm/tasks/jar_publish.py                             | 14 +++++++++++---
 testprojects/src/java/com/pants/testproject/publish/hello/greet/Greeting.java |  4 ++--
 testprojects/src/java/com/pants/testproject/publish/hello/greet/README.txt    |  3 +++
 tests/python/pants_test/tasks/test_jar_publish_integration.py                 |  7 ++++---
 4 files changed, 20 insertions(+), 8 deletions(-)

Locally, after testprojects/... commit but before
src/python/pants/backend/jvm/tasks/jar_publish.py commit:

$ PANTS_DEV=1 ./pants test tests/python/pants_test/tasks:jar_publish_integration -- -vs -k test_java_publish
...
                     E      Exception message: 'ascii' codec can't decode byte 0xe2 in position 249: ordinal not in range(128)

Success after commit of src/python/pants/backend/jvm/tasks/jar_publish.py fix.

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/51182953

Issues

  • 0
  • 0
  • 1
  • 1
Description From Last Updated
John Sirois
Jin Feng
John Sirois
David Turner
Eric Ayers
John Sirois
John Sirois
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...