Ivy Imports now has a cache

Review Request #1785 - Created Feb. 16, 2015 and submitted

Information
Eric Ayers
pants
zundel/mapjar-uses-cache
1097, 1103
1783
42d2537...
Reviewers
pants-reviews
benjyw, davidt, jsirois, patricklaw

Add an invalidation check to Ivy Imports

 git diff master --stat
 examples/src/protobuf/com/pants/examples/imports/BUILD            |   7 ----
 src/python/pants/backend/codegen/tasks/protobuf_gen.py            |   7 ++++
 src/python/pants/backend/jvm/targets/BUILD                        |   1 +
 src/python/pants/backend/jvm/targets/import_jars_mixin.py         |  34 +++++++++++++++++-
 src/python/pants/backend/jvm/targets/unpacked_jars.py             |   3 --
 src/python/pants/backend/jvm/tasks/ivy_imports.py                 |  84 +++++++++++++++++++++++++++++++++++++-------
 src/python/pants/backend/jvm/tasks/ivy_task_mixin.py              |  29 ++++++++++++++-
 src/python/pants/backend/jvm/tasks/unpack_jars.py                 |   2 +-
 tests/python/pants_test/backend/__init__.py                       |   0
 tests/python/pants_test/backend/jvm/__init__.py                   |   0
 tests/python/pants_test/backend/jvm/targets/test_unpacked_jars.py |  25 +++++++++++++
 tests/python/pants_test/backend/jvm/tasks/BUILD                   |  15 ++++++++
 tests/python/pants_test/backend/jvm/tasks/__init__.py             |   0
 tests/python/pants_test/backend/jvm/tasks/jvm_compile/__init__.py |   0
 tests/python/pants_test/backend/jvm/tasks/test_ivy_imports.py     | 123 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/python/pants_test/backend/jvm/tasks/test_unpack_jars.py     |  24 ++++++++-----
 16 files changed, 319 insertions(+), 35 deletions(-)

Added a new unit test for ivy-imports. Also ran this on targets in our own repo.

Issues

  • 0
  • 7
  • 5
  • 12
Description From Last Updated
Eric Ayers
Eric Ayers
John Sirois
Eric Ayers
Eric Ayers
Eric Ayers
Nick Howard (Twitter)
Benjy Weinberger
Nick Howard (Twitter)
Stu Hood
Stu Hood
Patrick Lawson
Eric Ayers
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks Nick, Stu & Patrick. Submitted at b944b38

Loading...