shlex the python run args.

Review Request #1782 — Created Feb. 16, 2015 and submitted

benjyw
pants
731416f...
pants-reviews
patricklaw
So we don't have to specify them using multiple cmd-line flags.
Jvm run already does this.

Ran this before and after.

NH
  1. looks okay to me, but could you add a test to test_python_run_integration.py that would fail without the shlex?

    1. I briefly tried, but arguments passed through our current integration test pipeline don't shlex (probably need to add shell=True to Popen(), and that will have knock-on effects). So that would be a much bigger change than I currently want to make.

  2. 
      
PA
  1. Ship It!
  2. 
      
BE
Review request changed

Status: Closed (submitted)

BE
  1. Submitted as c7a64a94721f9c852c00d94b8f39506d5f429ac4

  2. 
      
Loading...