Optionally adds a path value onto protoc's PATH befor launching it

Review Request #1756 — Created Feb. 12, 2015 and submitted

zundel
pants
zundel/protoc-path-option
1086
72597f5...
pants-reviews
ity, jsirois, patricklaw

Optionally adds a path value onto protoc's PATH before launching it. This is helpful
for handing protoc plugins.

Bandaid until I can get this implemented

https://docs.google.com/a/squareup.com/document/d/1mtzvjXkD-efFUIRjHAlyIdHRS1dyXVil5NI9wdFKGDE/edit#heading=h.vh9e98m9cqx

Ran this in our repo.

JS
  1. 
      
  2. How about:

    os.pathsep.join(self._extra_paths + protoc_environ['PATH'].split(os.pathsep))
    

    The main thing to fix is s/':'/os.pathsep/

  3. 
      
ZU
JS
  1. Ship It!
  2. 
      
ZU
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks for the review John. commit 48388d0

PA
  1. Ship It!
  2. 
      
Loading...