Trying to clean up a TODO in IvyTaskMixin

Review Request #1753 - Created Feb. 12, 2015 and submitted

Information
Eric Ayers
pants
zundel/cleanup-ivy-task-mixin
1084
95b951d...
Reviewers
pants-reviews
jsirois, patricklaw

Cleaning up a TODO in IvyTaskMixin around product_types.

IvyTaskMixin.ivy_resolve() populates a product named 'symlink_map' which I renamed
to ivy_resolve_symlink_map. This product is consumed by JavaDependency but never required anywhere. I suppose that since it has a 1:1 correlation with 'ivy_jar_products' this never caused a problem scheduling with the round engine.

I am doing this in an effort to try to understand caching better and need to do something very similar in order to make a caching version of IvyTaskMixin.mapjars().

I put a breakpoint in the function I removed and it never got called.

Issues

  • 0
  • 3
  • 1
  • 4
Description From Last Updated
Eric Ayers
Benjy Weinberger
Benjy Weinberger
Patrick Lawson
Nick Howard (Twitter)
Eric Ayers
Eric Ayers
Patrick Lawson
Eric Ayers
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks for the reviews Benjy & Patrick. John offered to work on tests related to rb1759 this weekend so I went ahead and submitted.
Commit 34ebbe1

Loading...