Fix TestAndroidBase task_type override miss.

Review Request #1751 — Created Feb. 11, 2015 and submitted

jsirois
pants
jsirois/android/cleanup_base_test
1080
a18afe3...
pants-reviews
mateor, zundel
The override attempt was against a classmethod in TaskTest but itself
was an instance method.  This was harmless, but also un-needed.  The
TaskTest base class raises and this is a better default, forcing the
TestAndroidBase leaves to implement.

 tests/python/pants_test/android/test_android_base.py | 4 ----
 1 file changed, 4 deletions(-)
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/50286508
JS
  1. Found this when coming up with the fix in https://rbcommons.com/s/twitter/r/1750/ - it had nothing to do with that break-fix, it just stood out as suspicious when pruning the debug tree of things to check.
  2. 
      
JS
ZU
  1. If you are fixing things, the BUILD file has this and the integration base classes listed as python_tests(), I think they should be python_library().
    Also add the dep '3rdparty/python/twitter/commons:twitter.common.collections' to 'android_base'

    1. Agreed.  Fixed + killed unused imports.
  2. 
      
IT
  1. Ship It!
  2. 
      
JS
MA
  1. Thanks John, Eric.

  2. 
      
JS
  1. Thanks folks - submitted @ https://github.com/pantsbuild/pants/commit/ef81ab300cdf3874048e6cc6aaeb08e2ee2bc4df
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...