Pass the BUILD file path to compile.

Review Request #1742 — Created Feb. 10, 2015 and submitted

jsirois
pants
jsirois/build_file/better_compile
1067
659318d...
pants-reviews
jinfeng, nhoward_tw
This produces SyntaxErrors with the path to the bad BUILD file included
in the error details.

 src/python/pants/base/build_file.py             |   2 +-
 tests/python/pants_test/base/BUILD              |   2 +-
 tests/python/pants_test/base/test_build_file.py | 211 +++++++++++++++++++++++++++-----------------------
 3 files changed, 115 insertions(+), 100 deletions(-)
CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/50115987
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
JS
  1. ping
  2. 
      
JI
  1. Ship It!
  2. 
      
JS
JS
  1. Thanks Jin - submitted @ https://github.com/pantsbuild/pants/commit/274df6c844634675af7d6f1657f14840e3480f25
  2. 
      
JS
Review request changed

Status: Closed (submitted)

PA
  1. 
      
  2. Sorry for the late review--we should always be using six equivalents rather than introducing new deps on t.c.*.; e.g. https://pythonhosted.org/six/#six.exec_

    1. Fixed up here: https://rbcommons.com/s/twitter/r/1794/
  3. 
      
NH
  1. Ship It!
  2. 
      
Loading...