Migrating pants.ini config values for protobuf-gen to advanced registered options under gen.protobuf

Review Request #1741 — Created Feb. 9, 2015 and submitted

Information
zundel
pants
zundel/protobuf-config-migrate
1066
2bd87b1...
Reviewers
pants-reviews
ity, jsirois 
Fixed a mistake in the way that 'plugins' was processed.  The suffix '_protobuf' is Square specific.
See https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.compiler.plugin.pb for
the docs which read:

```
The plugin should be named "protoc-gen-$NAME", and will then be used when the flag "--${NAME}_out" is passed to protoc.
```
Ran migrate_config against the Square repo pants.ini


Updated the pants.ini settings in the Square repo and ran with the development version of pants.
JS
jsirois 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    




    
    s/"javadeps"/"version"/
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I meant "javadeps" when I wrote it but I see now that its confusing.  I re-worded the text. PTAL.
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Ah yes.  The rewording makes sense.
      
 
      

      3. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   





 ZU





   

   

  

 



 















 





 

  

   





 JS





   

   







  

 



 

  


   

   

    
 
jsirois


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 ZU





   

   

  

 



 















 



 

  

   





 ZU





   

   

  

 



 















 



 

  

   





 ZU





   

   

  

 



 















 





 

  

   





 ZU





   

   





  

 



 

  


   

   

    
 
zundel


    
   


  

  

  



    




  1. 
 
    
  
    
   
    I had to revert this change, it broke the build.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 ZU





   

   

  

 



 















 





 

  

   





 JS





   

   







  

 



 

  


   

   

    
 
jsirois


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 ZU





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 




 
Change Summary:

 
resubmitted as commit 04a368c3617d3ceac60170f6a68428bdfd815cb1





 


 










  

 









     

    

   



  

  

   
   Loading...