Migrating pants.ini config values for protobuf-gen to advanced registered options under gen.protobuf
Review Request #1741 — Created Feb. 9, 2015 and submitted
Information | |
---|---|
zundel | |
pants | |
zundel/protobuf-config-migrate | |
1066 | |
2bd87b1... | |
Reviewers | |
pants-reviews | |
ity, jsirois |
Fixed a mistake in the way that 'plugins' was processed. The suffix '_protobuf' is Square specific. See https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.compiler.plugin.pb for the docs which read: ``` The plugin should be named "protoc-gen-$NAME", and will then be used when the flag "--${NAME}_out" is passed to protoc. ```
Ran migrate_config against the Square repo pants.ini
Updated the pants.ini settings in the Square repo and ran with the development version of pants.
Change Summary:
Updated migrate config help for "protobuf-gen", "version" pants.ini setting.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+50 -17) |
Change Summary:
PTAL: Fixed build breakage by adding back missing
return
from javadeps and pythondeps properties. Added unit test to catch this problem.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+79 -19) |