Kill BUILD file bytecode compilation.
Review Request #1736 - Created Feb. 7, 2015 and submitted
|benjyw, nhoward_tw, zundel|
This was a performance hack that is no longer clearly beneficial for speed and is clearly detrimental for inherent complexity. src/python/pants/base/build_file.py | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-)
CI went green here: https://travis-ci.org/pantsbuild/pants/builds/49920875
I'd really like to get all 3 reviewers - or representatives from their companies - to patch this change in and report back on before/after timings for `./pants list` in their large monorepos.
Cleanup build_file.py BUILD deps. src/python/pants/base/BUILD | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --publish
Revision 2 (+2 -23)
It's about the same performance wise from my tests. The difference is within the error bars of differences between runs.
Looking at profiling, it may be even be faster--marshal appears to take more time than read + compile.
off topic: Would it make make sense to use the BUILD file's name instead of
<string>for the compile filename argument?