cleanup is_xxx checks: is_jar_library

Review Request #1719 - Created Feb. 5, 2015 and submitted

Information
David Turner
pants
2c84dd9...
Reviewers
pants-reviews
ity, jsirois, patricklaw, zundel
Replace every instance of is_jar_library with isinstance check.  It's
a start.

https://travis-ci.org/pantsbuild/pants/builds/49652980

Issues

  • 0
  • 0
  • 1
  • 1
Description From Last Updated
John Sirois
Eric Ayers
David Turner
Eric Ayers
John Sirois
David Turner
Review request changed

Status: Closed (submitted)

Patrick Lawson

Just want to double check--none of these should have pulled in extra BUILD dependencies right?

Imports aren't sorted (though you didn't introduce the original bad import)

  1. Yeah, we should do another big import fix, and then introduce a check for that so it doesn't happen again.

    Everything compiles/tests OK, so we're not directly missing anything; we could probably add a few more explicit deps rather than relying on transitive deps, but I think we already do rely on transitive deps a fair amount.

Loading...