cleanup is_xxx checks: is_jar_library
Review Request #1719 - Created Feb. 5, 2015 and submitted
|ity, jsirois, patricklaw, zundel|
Replace every instance of is_jar_library with isinstance check. It's a start.
I am sorta OK with this and the removal of setting the label from jar_library . My reservations on removing them is that they are on target so could be used by anyone.
In the other patch I started, I left these methods in place with a message on what to use instead. I thought about doing a print("DEPRECATED...") style message like we have used for other deprecated functions... so that you'd see the problem right away in your repo if you updated to the latest version of pants without it actually breaking.
No longer remove method
Revision 2 (+7 -4)