Fixup the release script.

Review Request #1715 - Created Feb. 5, 2015 and submitted

Information
John Sirois
pants
jsirois/release/fix_release_tests
1037
cdecf66...
Reviewers
pants-reviews
jinfeng, lahosken
The release verification was failing due to objects registered in the
internal_backend present in BUILD files.  This change fixes the issue by
using the internal_backend during publish verification instead of
avoiding it.  This required 2 main changes:

1. Lift the internal_backend to its own top-level directory.
   This allows clean pythonpath adjoinment of the internal_backend in
   the main pants.ini.
2. Adapt the release script to retrieve the internal_backend
   dependencies.

 .travis.yml                                                                                             |  8 ++++----
 BUILD                                                                                                   |  4 ++++
 build-support/bin/check_header.sh                                                                       |  2 +-
 build-support/bin/ci.sh                                                                                 | 22 ++++++++++++++++++----
 build-support/bin/release.sh                                                                            | 22 ++++++++++++----------
 build-support/pants_venv                                                                                |  2 +-
 build-support/virtualenv                                                                                |  2 +-
 {3rdparty/python/internal_backend => pants-plugins/3rdparty/python}/BUILD                               |  0
 {3rdparty/python/internal_backend => pants-plugins/3rdparty/python}/requirements.txt                    |  0
 pants-plugins/README.md                                                                                 |  7 +++++++
 pants-plugins/src/python/internal_backend/BUILD                                                         | 11 +++++++++++
 {src/python/internal_backend/sitegen/tasks => pants-plugins/src/python/internal_backend}/__init__.py    |  0
 {src => pants-plugins/src}/python/internal_backend/optional/BUILD                                       |  0
 {src/python/internal_backend/sitegen => pants-plugins/src/python/internal_backend/optional}/__init__.py |  0
 {src => pants-plugins/src}/python/internal_backend/optional/register.py                                 |  0
 {src => pants-plugins/src}/python/internal_backend/repositories/BUILD                                   |  0
 {src => pants-plugins/src}/python/internal_backend/repositories/__init__.py                             |  0
 {src => pants-plugins/src}/python/internal_backend/repositories/register.py                             |  0
 {src => pants-plugins/src}/python/internal_backend/sitegen/BUILD                                        |  2 +-
 {src => pants-plugins/src}/python/internal_backend/sitegen/README.md                                    |  0
 {src/python/internal_backend/optional => pants-plugins/src/python/internal_backend/sitegen}/__init__.py |  0
 {src => pants-plugins/src}/python/internal_backend/sitegen/register.py                                  |  0
 {src => pants-plugins/src}/python/internal_backend/sitegen/tasks/BUILD                                  |  2 +-
 {src/python/internal_backend => pants-plugins/src/python/internal_backend/sitegen/tasks}/__init__.py    |  0
 {src => pants-plugins/src}/python/internal_backend/sitegen/tasks/sitegen.py                             |  0
 {tests => pants-plugins/tests}/python/internal_backend_test/BUILD                                       |  4 ++--
 {tests => pants-plugins/tests}/python/internal_backend_test/sitegen/BUILD                               |  4 ++--
 {tests => pants-plugins/tests}/python/internal_backend_test/sitegen/test_sitegen.py                     |  0
 pants.ini                                                                                               |  5 +++++
 pants.no.internal.backend.ini                                                                           |  9 ---------
 src/python/internal_backend/BUILD                                                                       | 11 -----------
 src/python/internal_backend/README.md                                                                   |  4 ----
 src/python/pants/backend/python/test_builder.py                                                         |  4 +++-
 src/python/pants/base/BUILD                                                                             |  1 +
 src/python/pants/bin/BUILD                                                                              |  3 +--
 35 files changed, 75 insertions(+), 54 deletions(-)

Failed before, works now: ./build-support/bin/release.sh -n

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/49628846

John Sirois
Larry Hosken
Eric Ayers
John Sirois
Eric Ayers
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...