Avoid redundant traversal in classpath calculation

Review Request #1714 - Created Feb. 5, 2015 and submitted

Information
David Turner
pants
19112b4...
Reviewers
pants-reviews
fkorotkov, ity, jsirois, nhoward_tw, zundel
There is no need to look at the jar_dependencies of jvm targets that
are not jar_libraries, because we are already walking them, and the
walk will visit their jar_library dependencies.  Also, there is no
need to visit a target more than once, so keep a set of targets we
have already processed, and do not allow our walk to descend into
those targets.

https://travis-ci.org/pantsbuild/pants/builds/49546993

For performance testing, ran ./pants goal resolve [some large directory]:: on a Twitter internal repo (from clean); total time saving is 40s.

Fedor Korotkov
John Sirois
Patrick Lawson
David Turner
David Turner
Nick Howard (Twitter)
Fedor Korotkov
Eric Ayers
David Turner
Review request changed

Status: Closed (submitted)

Loading...