Pants itself uses python2.7, kill unittest2 imports.

Review Request #1689 - Created Jan. 30, 2015 and submitted

Information
John Sirois
pants
jsirois/unittest/simplify
1011
e63e5c4...
Reviewers
pants-reviews
dturner-tw, mateor

The pants.backend.python.test_builder.PythonTestBuilder has a valid need
to depend on unittest2 for pre-2.7 or v3 pre-3.3 codebases using pants
to run python_tests targets. The pants test code itself does not have
this need since we dropped 2.6 support and require a 3.3+ interpreter if
running under 3 (eventually).

examples/tests/python/example_test/hello/greet/greet.py | 2 +-
examples/tests/python/example_test/usethriftpy/use_thrift_test.py | 4 ++--
tests/python/internal_backend_test/sitegen/test_sitegen.py | 3 +--
tests/python/pants_test/android/tasks/test_aapt_gen.py | 2 +-
tests/python/pants_test/android/test_android_distribution.py | 2 +-
tests/python/pants_test/backend/codegen/tasks/test_protobuf_parse.py | 2 +-
tests/python/pants_test/backend/jvm/test_jvm_debug_config.py | 3 ++-
tests/python/pants_test/base/test_abbreviate_target_ids.py | 2 +-
tests/python/pants_test/base/test_address.py | 2 +-
tests/python/pants_test/base/test_build_configuration.py | 2 +-
tests/python/pants_test/base/test_build_file.py | 2 +-
tests/python/pants_test/base/test_build_file_aliases.py | 2 +-
tests/python/pants_test/base/test_build_root.py | 2 +-
tests/python/pants_test/base/test_extension_loader.py | 16 +++++++++++++---
tests/python/pants_test/base/test_generator.py | 2 +-
tests/python/pants_test/base/test_revision.py | 2 +-
tests/python/pants_test/base/test_run_info.py | 2 +-
tests/python/pants_test/base/test_source_root.py | 2 +-
tests/python/pants_test/base_test.py | 2 +-
tests/python/pants_test/cache/test_artifact_cache.py | 8 ++++++--
tests/python/pants_test/engine/base_engine_test.py | 2 +-
tests/python/pants_test/fs/test_archive.py | 2 +-
tests/python/pants_test/fs/test_expand_path.py | 2 +-
tests/python/pants_test/fs/test_safe_filename.py | 2 +-
tests/python/pants_test/java/distribution/test_distribution.py | 2 +-
tests/python/pants_test/java/test_executor.py | 2 +-
tests/python/pants_test/option/test_arg_splitter.py | 2 +-
tests/python/pants_test/option/test_custom_types.py | 2 +-
tests/python/pants_test/option/test_option_value_container.py | 2 +-
tests/python/pants_test/option/test_options.py | 2 +-
tests/python/pants_test/option/test_options_bootstrapper.py | 2 +-
tests/python/pants_test/pants_run_integration_test.py | 2 +-
tests/python/pants_test/python/test_antlr_builder.py | 4 +++-
tests/python/pants_test/python/test_interpreter_cache.py | 9 +++------
tests/python/pants_test/python/test_resolver.py | 2 +-
tests/python/pants_test/python/test_thrift_namespace_packages.py | 2 +-
tests/python/pants_test/reporting/test_linkify.py | 3 ++-
tests/python/pants_test/scm/test_git.py | 2 +-
tests/python/pants_test/tasks/jvm_compile/scala/test_zinc_analysis.py | 2 +-
tests/python/pants_test/tasks/test_config.py | 2 +-
tests/python/pants_test/tasks/test_jar_library_with_overrides.py | 2 +-
tests/python/pants_test/tasks/test_jar_publish.py | 2 +-
tests/python/pants_test/tasks/test_jaxb_gen.py | 2 +-
tests/python/pants_test/tasks/test_markdown_to_html.py | 2 +-
tests/python/pants_test/tasks/test_protobuf_gen.py | 2 +-
tests/python/pants_test/test_thrift_util.py | 2 +-
tests/python/pants_test/util/test_contextutil.py | 2 +-
tests/python/pants_test/util/test_dirutil.py | 2 +-
tests/python/pants_test/util/test_keywords.py | 2 +-
tests/python/pants_test/util/test_strutil.py | 2 +-
50 files changed, 74 insertions(+), 60 deletions(-)

./build-support/bin/ci.sh went green locally.

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/48826516

David Turner
John Sirois
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Mateo Rodriguez
Ship It!
Loading...