Make apache thrift gen keyword modification more atomic

Review Request #1683 — Created Jan. 28, 2015 and submitted

dturner-tw
pants
219120c...
pants-reviews
ity, jsirois, nhoward_tw, patricklaw

Make apache thrift gen keyword modification more atomic (this is breaking things for us).

https://travis-ci.org/pantsbuild/pants/builds/48695315

+new test for fileutil

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
JS
  1. 
      
  2. src/python/pants/util/fileutil.py (Diff revision 1)
     
     

    2 blank lines

  3. src/python/pants/util/fileutil.py (Diff revision 1)
     
     

    pydoc please

  4. src/python/pants/util/fileutil.py (Diff revision 1)
     
     

    How about just leveraging tempfile uniqueness handling and just past dst as the basedir for the temp.

  5. src/python/pants/util/keywords.py (Diff revision 1)
     
     

    This will fail for anyone with tmpfs unless you want to make really stringent claims about valid source locaions in the function pydoc above.

  6. No need to do this any longer - we are on python2.7 minimum.

  7. 2 blank lines

  8. 
      
DT
JS
  1. 
      
  2. src/python/pants/util/fileutil.py (Diff revisions 1 - 2)
     
     

    A single blank line should separate stdlib imports from project imports... and keep 2 blank lines between imports and top-level functions.

  3. tests/python/pants_test/util/test_fileutil.py (Diff revisions 1 - 2)
     
     

    just import unittest is enough, unittest in python2.7+ is unittest2 (which was just a 3rdparty clone lib).

  4. 
      
DT
DT
Review request changed

Status: Closed (submitted)

JS
  1. 
      
  2. src/python/pants/util/fileutil.py (Diff revisions 2 - 3)
     
     

    and ... fully qualify this please - this line made me look 3x but I never stopped to figure out why.

    1. Oops; I already submitted. Here's the follow-up: https://rbcommons.com/s/twitter/r/1688/

  3. 
      
IT
  1. Ship It!
  2. 
      
Loading...