doc: JDK_HOME, JAVA_HOME, choosing distribution
Review Request #1678 - Created Jan. 28, 2015 and submitted
Stop doc'ing a quirk that got fixed approximately forever ago, as revealed in https://groups.google.com/forum/#!topic/pants-devel/WdiTfbTTZD0.
(I see Pants has a notion of a minimum/maximum version, but my naive grepping didn't tell me where we expect the user to config/set this, so I didn't mention it. But if a reviewer knows, that's lovely.)
I have a very similar patch that I have been sitting on for (gasp) almost 4 months. That is because I am not sure that we would be changing the right thing. Adding something to the PATH to change Java versions sounds more conveniant than the way we actually have it set up. I might vote to change the Distribution class to match the docs as opposed to the other way around.
If we do decide to just correct the docs, then the very next sentence (about how to set a one-timejava version) needs to be changed as well, since the code is just going to use whatever it finds at JDK_HOME or JAVA_HOME no matter what the user does to PATH.
excellent feedback is excellent: update the example, too
Not super-sure I got it right; I'm not sure how to tell which Java Pants "found". I think when I switched from one to the other it built a lot, though I didn't do a clean-all in between. Which might mean I got it to use another Java. Or might mean I was staring at some debug output and reading too much at it.
Revision 2 (+2 -2)