Fix bug that caused pex not to cache the results of translation.

Review Request #1666 — Created Jan. 25, 2015 and submitted — Latest diff uploaded

ugodiggi
pex
ugodiggi:cache_translation_results
https://github.com/pantsbuild/pex/pull/35
573a5e5...
pants-reviews
patricklaw, wickman

Fix bug that caused pex not to cache the results of translation.

I'm under the impression that this is a simple "typo" error, and the intention was also to pass through the parameter to the chained translators.

Of course it's possible that this was intentional and I'm really missing the point :-)

This works well and seems to cache artifacts correctly in the UrbanCompass code base.

Of course I also run the tests (only for py27 though, that's all I have on this system):

$ tox
GLOB sdist-make: /Users/ugo/development/pex/setup.py
pypy-requests create: /Users/ugo/development/pex/.tox/pypy-requests
ERROR: InterpreterNotFound: pypy
py27-requests create: /Users/ugo/development/pex/.tox/py27-requests
py27-requests installdeps: pytest, twitter.common.contextutil>=0.3.1,<0.4.0, twitter.common.dirutil>=0.3.1,<0.4.0, twitter.common.lang>=0.3.1,<0.4.0, twitter.common.testing>=0.3.1,<0.4.0, wheel, mock, requests, responses
py27-requests inst: /Users/ugo/development/pex/.tox/dist/pex-0.8.3.zip
py27-requests runtests: PYTHONHASHSEED='2621098136'
py27-requests runtests: commands[0] | py.test
============================================================================================================ test session starts =============================================================================================================
platform darwin -- Python 2.7.8 -- py-1.4.26 -- pytest-2.6.4
collected 56 items

tests/test_archiver.py .
tests/test_compatibility.py .
tests/test_crawler.py ......
tests/test_environment.py ...
tests/test_finders.py ....
tests/test_http.py ..........
tests/test_integration.py ...
tests/test_interpreter.py .
tests/test_iterator.py ...
tests/test_link.py ...
tests/test_package.py ..
tests/test_pep425.py ..
tests/test_pex.py ....
tests/test_pex_bootstrapper.py .
tests/test_pex_builder.py .
tests/test_pex_info.py .
tests/test_platform.py .....
tests/test_resolver.py ..
tests/test_util.py ...

========================================================================================================= 56 passed in 8.33 seconds ==========================================================================================================
py34-requests create: /Users/ugo/development/pex/.tox/py34-requests
ERROR: InterpreterNotFound: python3.4
style create: /Users/ugo/development/pex/.tox/style
style installdeps: twitter.checkstyle
style inst: /Users/ugo/development/pex/.tox/dist/pex-0.8.3.zip
style runtests: PYTHONHASHSEED='2621098136'
style runtests: commands[0] | twitterstyle -n ImportOrder /Users/ugo/development/pex/pex /Users/ugo/development/pex/tests
isort-check create: /Users/ugo/development/pex/.tox/isort-check
isort-check installdeps: isort
isort-check inst: /Users/ugo/development/pex/.tox/dist/pex-0.8.3.zip
isort-check runtests: PYTHONHASHSEED='2621098136'
isort-check runtests: commands[0] | isort -ns init.py -rc -c /Users/ugo/development/pex/pex /Users/ugo/development/pex/tests
__________________ summary ___________________
SKIPPED: pypy-requests: InterpreterNotFound: pypy
py27-requests: commands succeeded
SKIPPED: py34-requests: InterpreterNotFound: python3.4
style: commands succeeded
isort-check: commands succeeded
congratulations :)

Loading...