bump jmake to version with isPackagePrivateClass fix

Review Request #1650 — Created Jan. 23, 2015 and submitted

dturner-tw
pants
a2b4f46...
pants-reviews
jsirois, zundel
bump jmake to version with isPackagePrivateClass fix

https://travis-ci.org/pantsbuild/pants/builds/48100463

JS
  1. It looks like my attempt to harden the release script to ensure java 6 compat was not successful:

    $ mkdir /tmp/jmake && unzip -qd /tmp/jmake ~/desktop/jmake-1.3.8-9.jar 
    $ find /tmp/jmake -name "*.class" | xargs file
    /tmp/jmake/org/pantsbuild/jmake/Base64.class:                                               compiled Java class data, version 51.0
    /tmp/jmake/org/pantsbuild/jmake/Base64Test.class:                                           compiled Java class data, version 51.0
    /tmp/jmake/org/pantsbuild/jmake/BinaryFileReader.class:                                     compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/BinaryFileWriter.class:                                     compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/BinaryProjectDatabaseReader.class:                          compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/BinaryProjectDatabaseWriter$StringHashTable.class:          compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/BinaryProjectDatabaseWriter.class:                          compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/ClassFileReader.class:                                      compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/ClassFileReaderTest.class:                                  compiled Java class data, version 51.0
    /tmp/jmake/org/pantsbuild/jmake/ClassInfo$MethodHandler.class:                              compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/ClassInfo.class:                                            compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/ClassPath$1.class:                                          compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/ClassPath$Dir.class:                                        compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/ClassPath$PathEntry.class:                                  compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/ClassPath$Zip.class:                                        compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/ClassPath.class:                                            compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/CompatibilityChecker$1.class:                               compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/CompatibilityChecker$2.class:                               compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/CompatibilityChecker.class:                                 compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/CompileResult.class:                                        compiled Java class data, version 51.0
    /tmp/jmake/org/pantsbuild/jmake/Main.class:                                                 compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/MainTest.class:                                             compiled Java class data, version 51.0
    /tmp/jmake/org/pantsbuild/jmake/PCDContainer.class:                                         compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/PCDEntry.class:                                             compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/PCDManager.class:                                           compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/PCDManagerTest.class:                                       compiled Java class data, version 51.0
    /tmp/jmake/org/pantsbuild/jmake/PCDSerializationTest.class:                                 compiled Java class data, version 51.0
    /tmp/jmake/org/pantsbuild/jmake/PrivateException.class:                                     compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/PublicExceptions$ClassFileParseException.class:             compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/PublicExceptions$ClassNameMismatchException.class:          compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/PublicExceptions$CommandFileReadException.class:            compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/PublicExceptions$CompilerInteractionException.class:        compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/PublicExceptions$DoubleEntryException.class:                compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/PublicExceptions$InternalException.class:                   compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/PublicExceptions$InvalidCmdOptionException.class:           compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/PublicExceptions$InvalidSourceFileExtensionException.class: compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/PublicExceptions$JarDependsOnSourceException.class:         compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/PublicExceptions$NoActionRequestedException.class:          compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/PublicExceptions$PDBCorruptedException.class:               compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/PublicExceptions.class:                                     compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/RefClassFinder$1.class:                                     compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/RefClassFinder.class:                                       compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/TestCase1.class:                                            compiled Java class data, version 51.0
    /tmp/jmake/org/pantsbuild/jmake/TestDepFile.class:                                          compiled Java class data, version 51.0
    /tmp/jmake/org/pantsbuild/jmake/TestPCDUtils$1.class:                                       compiled Java class data, version 51.0
    /tmp/jmake/org/pantsbuild/jmake/TestPCDUtils.class:                                         compiled Java class data, version 51.0
    /tmp/jmake/org/pantsbuild/jmake/TextProjectDatabaseReader.class:                            compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/TextProjectDatabaseWriter.class:                            compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/Utils.class:                                                compiled Java class data, version 49.0 (Java 1.5)
    /tmp/jmake/org/pantsbuild/jmake/UtilsTest.class:                                            compiled Java class data, version 51.0
    /tmp/jmake/org/pantsbuild/jmake/ant/JavaMake.class:                                         compiled Java class data, version 51.0
    

    Most of the version 51.0 (java 7) classfiles look like tests, although these 3 look like library code:

    /tmp/jmake/org/pantsbuild/jmake/Base64.class:                                               compiled Java class data, version 51.0
    /tmp/jmake/org/pantsbuild/jmake/CompileResult.class:                                        compiled Java class data, version 51.0
    /tmp/jmake/org/pantsbuild/jmake/ant/JavaMake.class:                                         compiled Java class data, version 51.0
    

    This is fine for now though since pantsbuild/pants itself java6 requirement and no devs have barked about this, only a spike to smoke out causes of https://github.com/pantsbuild/pants/issues/942 hit the issue on a travis java 6 shard.

    1. I cannot get anything but '1.5' (bytcode version 49) out of my box. Also, I'm not sure how you're getting test classes jarred up. Maybe we need to add 'ant clean' to the beginning of the release script?

    2. The tests shouldn't even be there. I've reposted a new version which should be correct (although I have not checked).

    3. I checked - no test classes and all version 49.0 - lgtm.

    4. +ant clean https://rbcommons.com/s/twitter/r/1651/

  2. 
      
DT
Review request changed

Status: Closed (submitted)

Loading...